fix q value calculation #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## developer #172 +/- ##
=============================================
+ Coverage 17.37% 18.17% +0.80%
=============================================
Files 114 114
Lines 9284 9340 +56
Branches 1150 1150
=============================================
+ Hits 1613 1698 +85
+ Misses 7393 7359 -34
- Partials 278 283 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
Please list the changes introduced in this PR
fix q value calculation
fix q value robust calculation
update documentation
add q value unit test
add q value robust unit test
The project builds without problems on your machine
Added unit tests regarding the added features