Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Our current i18n release management workflow gets everything right on the securedrop-i18n/i18n branch, but doesn't ensure that the PO template is updated back on the
develop
branch. This PR bringssecuredrop/translations/messages.pot
up to date. A documentation update is pending to reduce the chance of this happening in the future.Testing
Put this in a script called
ckpo.py
:git checkout develop
securedrop
working copy, runPYTHONPATH=securedrop /path/to/ckpo.py
The output should contain four
WARNING
lines which you can ignore, and quite a few "message not present" errors. Those are strings which no longer exist in our code.git checkout -b update-translation-messages origin/update-translation-messages
ckpo.py
again. This time there should only be the four ignorableWARNING
lines, and 13 icon alt text strings that have not been translated to Hindi, which is accurate. If this matches what you see, themessages.pot
file now matches the translatable strings in our source.Deployment
This doesn't affect the production message catalogs.
Checklist
If you made non-trivial code changes:
Choose one of the following: