-
-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(curriculum): add registration form practice project #42876
Conversation
curriculum/challenges/english/01-responsive-web-design/registration-form/final.md
Outdated
Show resolved
Hide resolved
I spent so long thinking this PR was already merged 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Findings from completing project once.
More general note - there doesn't seem to be part with adding value
attribute to the radio
and checkbox
inputs
Some specific things below.
curriculum/challenges/english/01-responsive-web-design/registration-form/part-033.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-042.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-046.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-047.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-051.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-022.md
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-039.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks real good @ShaunSHamilton 🎉
I left a number of suggestions - Many could be considered a preference and aren't necessary to add, others might just be thoughts or observations. Looks like @gikf left some suggestions for a number of the tests I was struggling with.
Some overall thoughts:
Seemed like some of the lessons could have maybe been broken up a little more. At the start I add 4 label elements at once - then 4 inputs at once, one in each - and 4 types... it's kind of a lot - I'm not saying it's wrong or needs to be changed - maybe something to keep in mind for the future. One way I might have done it is to do a single element, then the next three - for instance, 1 label in a step, then 1 input, then 1 type - followed by the last 3 labels, inputs, types... per step. Hope that makes sense.
There were some that could maybe have used more explanation - that's tough, because you don't want to get too wordy. For instance though, when a new element is introduced, say the radio buttons, you aren't really told what they do - for the most part, the elements are pretty self explanatory so it's not really that big of a deal - and as you build the project, you kind of just figure it out.
Another thing I would maybe like to see is some like "try it in the preview" sentences to try and get users more engaged. For instance, maybe when it mentioned that password inputs are hidden it could say something like "try it in the preview to make sure the input is hidden" - or when you set the min width of something: "resize the preview to make sure it works" - perhaps we don't want any of that, I'm not sure - but I think it adds some engagement
One frustrating thing I may have mentioned on another review is that when adding something I want to see in the preview - specifically, when I was styling the submit button - I want to see it - but every time I add a property, the preview refreshes and sends me to the top of the page. So I scroll down, and add another property, and it sends me to the top again - not much we can do about that I don't think. And I suppose that's the same as the current curriculum preview.
I don't think of the above needs to be changed here - just sharing my thoughts - maybe something to keep in mind.
Like I said - this looks real good 👍 You can tell how much thought went into it.
curriculum/challenges/english/01-responsive-web-design/registration-form/part-010.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-016.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-020.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-025.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-049.md
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-050.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-054.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-055.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-057.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com> Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming along nicely.
I have a couple of tiny nitpicks, but the bulk of this is ready to go.
curriculum/challenges/english/01-responsive-web-design/registration-form/part-006.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-008.md
Show resolved
Hide resolved
curriculum/challenges/english/01-responsive-web-design/registration-form/part-018.md
Show resolved
Hide resolved
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM 🎉
Edit: I can approve this: use clear, Tom-like language for 038
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this. Nice work Shaun!
Checklist:
Update index.md
)main
branch of freeCodeCamp.Adds the Registration Form practice project to the upcoming curriculum.