Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double slashes in Strip control codes challenge #38466

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Remove double slashes in Strip control codes challenge #38466

merged 2 commits into from
Mar 30, 2020

Conversation

agatapst
Copy link
Contributor

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #38436

@gitpod-io
Copy link

gitpod-io bot commented Mar 29, 2020 •
edited
Loading

RandellDawson
RandellDawson suggested changes Mar 29, 2020
View reviewed changes
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agatapst Since most of the testStrings have been modified, can you please go ahead and remove the unnecessary assert message arguments? You can click Commit suggestion for each and a commit will be made.

...rview-prep/rosetta-code/strip-control-codes-and-extended-characters-from-a-string.english.md Outdated Show resolved Hide resolved
...rview-prep/rosetta-code/strip-control-codes-and-extended-characters-from-a-string.english.md Outdated Show resolved Hide resolved
...rview-prep/rosetta-code/strip-control-codes-and-extended-characters-from-a-string.english.md Outdated Show resolved Hide resolved
...rview-prep/rosetta-code/strip-control-codes-and-extended-characters-from-a-string.english.md Outdated Show resolved Hide resolved
...rview-prep/rosetta-code/strip-control-codes-and-extended-characters-from-a-string.english.md Outdated Show resolved Hide resolved
...rview-prep/rosetta-code/strip-control-codes-and-extended-characters-from-a-string.english.md Outdated Show resolved Hide resolved
...rview-prep/rosetta-code/strip-control-codes-and-extended-characters-from-a-string.english.md Outdated Show resolved Hide resolved
@agatapst @RandellDawson
Remove unnecessary message argument from assertions
eaa5dad 
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
@agatapst
Copy link
Contributor Author

@RandellDawson Yes, thank you! 😊

@agatapst agatapst requested a review from RandellDawson March 29, 2020 21:04
ojeytonwilliams
ojeytonwilliams approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit 02f5609 into freeCodeCamp:master Mar 30, 2020
@ojeytonwilliams
Copy link
Contributor

@agatapst Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝

abbathaw pushed a commit to abbathaw/freeCodeCamp that referenced this pull request Jul 24, 2020
@agatapst @RandellDawson @abbathaw
Remove double slashes in Strip control codes challenge (freeCodeCamp#…
1695d89 
…38466)

* Remove double slashes in Strip control codes challenge

* Remove unnecessary message argument from assertions

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

@RandellDawson RandellDawson RandellDawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rosetta Code-Strip Control Codes: Assertions Assert Incorrect Strings
3 participants
@agatapst @ojeytonwilliams @RandellDawson