Added Documentation for React-bootstrap #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon04
requested changes
Feb 22, 2021
| @@ -0,0 +1,17 @@ | |||
| module Docs | |||
| class ReactBootstrap | |||
| class CleanHtmlFilter < Filter | |||
There was a problem hiding this comment.
Please clean as much from the original HTML as possible:
- Unwrap
._page _simple(in particular to make some CSS selectors of DevDocs effective). - A non exhaustive list of classes that should be removed:
___gatsby,gatsby-focus-wrapper,flex-xl-nowrap row,Heading-styles-module--heading--3cEKx __heading,ReactPlayground-StyledContainer-module--cls2--3Uz4N ReactPlayground-StyledContainer-module--cls1--1Jg9m-- As a rule of thumb, we try to remove every class which is not strictly necessary to minimize the docs size.
There was a problem hiding this comment.
Hi @simon04 , thanks for the review, I have fixed the second bullet point, which is to remove most of the unnecessary classes. But I would like to keep the styling as "simple" please. As the default "simple" stylesheet looks pretty good in my opinion.
Co-authored-by: Simon Legner <Simon.Legner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you’re adding a new scraper, please ensure that you have:
public/icons/your_scraper_name/directory:16.png: a 16×16 pixel icon for the doc16@2x.png: a 32×32 pixel icon for the docSOURCE: A text file containing the URL to the page the image can be found on or the URL of the original image itself