Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse SWGB DRS archives #14

Merged
merged 1 commit into from
Sep 24, 2015
Merged

Parse SWGB DRS archives #14

merged 1 commit into from
Sep 24, 2015

Conversation

phrohdoh
Copy link
Contributor

Ref #6.

fredreichbier added a commit that referenced this pull request Sep 24, 2015
@fredreichbier
Merge pull request #14 from Phrohdoh/swgb
069b884 
Parse SWGB DRS archives
@fredreichbier fredreichbier merged commit 069b884 into fredreichbier:master Sep 24, 2015
@fredreichbier
Copy link
Owner

Thanks for the PR! I had to make a quick fix in 154f15b because I got an error from construct:

...
  File ".../lib/python2.7/site-packages/construct/core.py", line 104, in __init__
    raise TypeError("name must be a string or None", name)
TypeError: ('name must be a string or None', PaddedStringAdapter('copyright'))

With these changes, I can still read AOE DRS files. Can you confirm that it now works for SWGB as well?

@phrohdoh phrohdoh deleted the swgb branch September 24, 2015 22:12
@phrohdoh
Copy link
Contributor Author

I'll test once I reinstall SWGB in the future. Sorry I completely missed that first parameter.

@fredreichbier
Copy link
Owner

Hi, no problem! As the patch does not break AOE DRS, I'll just keep the patch and keep #6 opened until someone confirms that SWGB indeed works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phrohdoh @fredreichbier