Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: frappe/bench
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.16.4
Choose a base ref
...
head repository: frappe/bench
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.17.0
Choose a head ref
  • 6 commits
  • 14 files changed
  • 3 contributors

Commits on Aug 7, 2023

  1. Copy the full SHA
    77ebdbe View commit details
  2. refactor!: Reuse redis_cache instace for socketio (#1382)

    WARNING: Just a POC. You're free to modify your setup to test this out.
    
    Summary:
    - After this change bench wont generate config for redis_socketio
      instance.
    - Instead we set the same port as redis_cache service for use in
      socketio. i.e. both will share same instance.
    
    Code changes:
    
    - Config will have this difference:
    
    ```diff
    - "redis_socketio": "redis://localhost:12000",
    - "redis_cache": "redis://localhost:13000",
    + "redis_socketio": "redis://localhost:13000",
    + "redis_cache": "redis://localhost:13000",
    ```
    
    - supervisord/systemd wont start redis_socketio service
    - for development setups: redis_socketio service is removed from procfile.
    
    Why?
    
    - Currently this redis instance is used only to ship messages from python
    to nodejs server... which is largely stateless (only pub/sub channels)
    - This change reduces 1 running process. Less resources for this ~= more
      resources for other running things.
    
    TODO:
    - [ ] decicisions - should we even do this? this should be optinal?
    - [ ] refactor progressbar in frappe
    - [ ] Tests - manual, FC, docker, automated
    - [ ] "migration" plan
    
    All dependent deployment projects will likely have to refactor their code to drop this service, shouldn't be too much work.
    Example: Frappe cloud, Frappe Docker.
    ankush authored Aug 7, 2023
    Copy the full SHA
    87efb75 View commit details
  3. Copy the full SHA
    5a2c052 View commit details

Commits on Aug 8, 2023

  1. Copy the full SHA
    ffe969b View commit details
  2. Copy the full SHA
    ffabe3a View commit details
  3. chore(release): Bumped to Version 5.17.0

    # [5.17.0](v5.16.4...v5.17.0) (2023-08-08)
    
    ### Features
    
    * Multi queue consumption ([#1475](#1475)) ([5a2c052](5a2c052))
    semantic-release-bot committed Aug 8, 2023
    Copy the full SHA
    62d040a View commit details
Loading