-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: frappe/bench
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.16.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: frappe/bench
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.17.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 14 files changed
- 3 contributors
Commits on Aug 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 77ebdbe - Browse repository at this point
Copy the full SHA 77ebdbeView commit details -
refactor!: Reuse redis_cache instace for socketio (#1382)
WARNING: Just a POC. You're free to modify your setup to test this out. Summary: - After this change bench wont generate config for redis_socketio instance. - Instead we set the same port as redis_cache service for use in socketio. i.e. both will share same instance. Code changes: - Config will have this difference: ```diff - "redis_socketio": "redis://localhost:12000", - "redis_cache": "redis://localhost:13000", + "redis_socketio": "redis://localhost:13000", + "redis_cache": "redis://localhost:13000", ``` - supervisord/systemd wont start redis_socketio service - for development setups: redis_socketio service is removed from procfile. Why? - Currently this redis instance is used only to ship messages from python to nodejs server... which is largely stateless (only pub/sub channels) - This change reduces 1 running process. Less resources for this ~= more resources for other running things. TODO: - [ ] decicisions - should we even do this? this should be optinal? - [ ] refactor progressbar in frappe - [ ] Tests - manual, FC, docker, automated - [ ] "migration" plan All dependent deployment projects will likely have to refactor their code to drop this service, shouldn't be too much work. Example: Frappe cloud, Frappe Docker.
Configuration menu - View commit details
-
Copy full SHA for 87efb75 - Browse repository at this point
Copy the full SHA 87efb75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a2c052 - Browse repository at this point
Copy the full SHA 5a2c052View commit details
Commits on Aug 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ffe969b - Browse repository at this point
Copy the full SHA ffe969bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffabe3a - Browse repository at this point
Copy the full SHA ffabe3aView commit details -
chore(release): Bumped to Version 5.17.0
# [5.17.0](v5.16.4...v5.17.0) (2023-08-08) ### Features * Multi queue consumption ([#1475](#1475)) ([5a2c052](5a2c052))
Configuration menu - View commit details
-
Copy full SHA for 62d040a - Browse repository at this point
Copy the full SHA 62d040aView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.16.4...v5.17.0