Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow autoparcel.vm resource instead of templateStr variable #27

Merged
merged 1 commit into from
Jun 14, 2015

Conversation

yongjhih
Copy link
Contributor

@yongjhih yongjhih commented Jun 5, 2015

No description provided.

@yongjhih yongjhih force-pushed the autoparcel_vm branch 2 times, most recently from 4ddbc60 to c2d266c Compare June 5, 2015 11:23
@frankiesardo
Copy link
Owner

Could you just move the autoparcel.vm under resources instead of adding the src folder in the build.gradle file?

@yongjhih
Copy link
Contributor Author

yongjhih commented Jun 5, 2015

auto.parcel.processor.AutoParcelTemplateVars.class.getResourceAsStream(resource); - It's going to load corresponding package path of $resources.srcDirs/auto/parcel/processo/$resource.

It's easier way by adding java folder into resources.srcDirs.

I don't sure how to move vm to resources without modify loader code snippet or move autoparcel.vm to resources/auto/parcel/processor/autoparcel.vm. I'm outdoor now, i'll check that later.

@yongjhih
Copy link
Contributor Author

yongjhih commented Jun 5, 2015

Here is another way by moving autoparcel.vm to corresponding resources path of src/main/resources/auto/parcel/processor/autoparcel.vm:

https://github.com/yongjhih/auto-parcel/tree/auto-parcel_vm2

auto.parcel.processor.AutoParcelTemplateVars.class.getResourceAsStream(resource); - It's going to load corresponding package path of $resources.srcDirs/auto/parcel/processo/$resource.

In this case, we have only one of resources. So I perfer adding src/main/java to $resources.srcDirs avoid maintain both package path of $java.srcDirs and $resources.srcDirs in the same.

@frankiesardo
Copy link
Owner

I'd rather not mix the concept of source code and static resources, so I'm happy to merge the second PR

@yongjhih
Copy link
Contributor Author

yongjhih commented Jun 9, 2015

It's not bad. I'll force-update this PR for regular structure.

frankiesardo added a commit that referenced this pull request Jun 14, 2015
Allow autoparcel.vm resource instead of templateStr variable
@frankiesardo frankiesardo merged commit d7512c0 into frankiesardo:master Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants