Allow AppConstants properties in Ant scripts #913
Conversation
|
|
||
| // iterate over appConstants and add them as properties | ||
| AppConstants appConstants = AppConstants.getInstance(); | ||
| @SuppressWarnings("unchecked") | ||
| Enumeration<String> enums = (Enumeration<String>) appConstants.propertyNames(); | ||
| while (enums.hasMoreElements()) { | ||
| String key = enums.nextElement(); | ||
| ant.setProperty(key, appConstants.getResolvedProperty(key)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Je voegt nu deze AppConstants-properties toe aan de FileSender. Ligt het niet meer voor de hand om ze op een hoger niveau toe te voegen, zodat je de AppConstants ook op andere plekken in Larva kunt gebruiken?
There was a problem hiding this comment.
Without this pull request, Larva allows you already to use AppConstants properties in scenario files, include files and input files. Niels has decided that properties should not be supported in output files; I have forgotten the reason. Only the option to use AppConstants properties in Ant scripts is missing. Adding this is the purpose of this pull request.
There was a problem hiding this comment.
See this PR which enabled resolving properties in input files #730
The reason Niels decided not to resolve properties in output files is that it will break the save result feature, since it will save the resolved property instead of the unresolved one.
Another reason that in output files it shouldn't be necessary, you can accomplish the same result with applying ignores to your scenario.
nielsm5
changed the title
No description provided.