Add possibility to declare ignores based on identifiers instead of numeric values in Larva #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Laurens,
|
added 3 commits
July 17, 2020 10:03
I wrote a bit of documentation of these options a while ago, it's available on https://knowhow.interpar.nl/?epkb_post_type_1=larva-ignores and Martijn knows this document exists, he will process it into the manual. I also added the "formatDecimalContentBetweenKeys" to this PR. |
Laurens-makel
changed the title
gvanbrakel
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you define ignores as with appended numeric suffixes:
ignoreContentBetweenKeys1.key1=<field name="ignoreMe">ignoreContentBetweenKeys1.key2=</field>ignoreContentBetweenKeys2.key1=<field name="ignoreMe2">ignoreContentBetweenKeys2.key2=</field>This has a lot of maintenance issues, declaring generic ignores in common.properties and extending them in specific scenarios is possible, but when a new generic one is introduced, all scenarios that depend on common.properties have to be changed..
This PR will make it possible to declare your (generic) ignores with an identifier instead of a numeric suffix, for example:
ignoreContentBetweenKeys.ignoreMe.key1=<field name="ignoreMe">ignoreContentBetweenKeys.ignoreMe.key2=</field>ignoreContentBetweenKeys.ignoreMeToo.key1=<field name="ignoreMe2">ignoreContentBetweenKeys.ignoreMeToo.key2=</field>Ofcourse the 'old' way will still work, but this extra feature will give developers more flexibility in creating test scenarios with a common base.
TODO:
Create test scenarios for each ignore property to provide proof of working code.