Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move placeholder text on edit-trigger page to a 'hint' #8032

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

nielsm5
Copy link
Member

@nielsm5 nielsm5 commented Nov 30, 2024

It's a lot of text, and it overflows if there is not enough space. It's not the best solution but for now it's the easiest...
Placeholders do not work when there is a default value. Though this not the best solution, and perhaps we should revamp all the forms, but at least it improves the current user-flow a bit...

It's a lot of text, and it overflows if there is not enough space. It's not the best solution but for now it's the easiest...
@nielsm5 nielsm5 linked an issue Nov 30, 2024 that may be closed by this pull request
@nielsm5 nielsm5 requested a review from Matthbo November 30, 2024 16:07
@nielsm5 nielsm5 changed the title Update monitors-add-edit.component.html Move placeholder text on edit-trigger page to a 'hint' Nov 30, 2024
Copy link
Member

@Matthbo Matthbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the hints need to be so extensive?
Wouldn't something like (Amount of triggers before alarming) & (Amount of seconds) be clear enough?

@nielsm5
Copy link
Member Author

nielsm5 commented Nov 30, 2024

Do the hints need to be so extensive? Wouldn't something like (Amount of triggers before alarming) & (Amount of seconds) be clear enough?

I think amount of triggers could work, but the period might require a bit more then just 'amount of seconds'. I'm unsure but open to suggestions! Perhaps 'Threshold timeframe in seconds' ?

@nielsm5 nielsm5 requested a review from evandongen December 2, 2024 09:36
@nielsm5 nielsm5 merged commit dbef124 into master Dec 2, 2024
23 checks passed
@nielsm5 nielsm5 deleted the nielsm5-patch-3 branch December 2, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitoring: I would like to see a time unit in label Period
3 participants