Parameterize Receiver and Listener types #710
Conversation
| @@ -852,7 +852,7 @@ private void moveInProcessToError(String originalMessageId, String correlationId | |||
| } | |||
| } | |||
| if (errorStorage!=null) { | |||
| errorStorage.storeMessage(originalMessageId, correlationId, receivedDate, comments, null, sobj); | |||
| errorStorage.storeMessage(originalMessageId, correlationId, receivedDate, comments, null, (M)sobj); | |||
There was a problem hiding this comment.
Wat als sobj hier een MessageWrapper is?
|
Er is een structuurprobleem, waardoor dat wat dit PR beoogt nu niet kan. |
| * Basic browser of JMS Messages. | ||
| * @author Gerrit van Brakel | ||
| */ | ||
| public class JmsBrowser<M extends Message> extends JmsMessageBrowser<M,M> { |
There was a problem hiding this comment.
Misschien toch wel handig om ipv een import hier javax.jms.Message te gebruiken?
| */ | ||
| public class JmsMessageBrowser extends JMSFacade implements IMessageBrowser { | ||
| public abstract class JmsMessageBrowser<M, J extends Message> extends JMSFacade implements IMessageBrowser<M> { |
| } | ||
|
|
||
| PipeLineSessionBase.setListenerParameters(context, null, correlationId, tsReceived, tsSent); | ||
| String messageId = (String) context.get("id"); | ||
| return processMessageInAdapter(origin, message, message, messageId, correlationId, context, waitingTime, false); | ||
| return processMessageInAdapter(origin, (M)message, message, messageId, correlationId, context, waitingTime, false); |
There was a problem hiding this comment.
Je kan toch zomaar een string naar een M casten?
| @@ -938,19 +938,19 @@ public void processRawMessage(IListener origin, Object rawMessage, Map threadCon | |||
|
|
|||
| * Assumes that a transation has been started where necessary. | |||
| */ | |||
| private void processRawMessage(IListener origin, Object rawMessage, Map threadContext, long waitingDuration, boolean manualRetry) throws ListenerException { | |||
| private void processRawMessage(IListener<M> origin, Object rawMessage, Map<String,Object>threadContext, long waitingDuration, boolean manualRetry) throws ListenerException { | |||
There was a problem hiding this comment.
Moet rawmessage dan geen M zijn?
No description provided.