Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / cleanup AppConstants #5302

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Conversation

nielsm5
Copy link
Member

@nielsm5 nielsm5 commented Aug 29, 2023

No description provided.

@nielsm5 nielsm5 marked this pull request as ready for review September 5, 2023 15:51
@nielsm5 nielsm5 changed the title Move AppConstants to commons module Refactor / cleanup AppConstants Sep 5, 2023
@nielsm5 nielsm5 requested a review from tnleeuw September 5, 2023 15:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

1.6% 1.6% Coverage
37.2% 37.2% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nielsm5 nielsm5 merged commit 1e05f6d into master Sep 6, 2023
@nielsm5 nielsm5 deleted the feature/AppConstantsToCommons branch September 6, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants