Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and accommodate configuration2mermaid.xsl and make changes to adapter2mermaid.xsl #3190

Merged
merged 15 commits into from
Nov 16, 2023

Conversation

lenardvandermaas
Copy link
Contributor

@lenardvandermaas lenardvandermaas commented May 17, 2022

Add an xsl that will create a mermaid configuration for Frank configurations. Java code has been changed to use this new xsl instead of the xsl that is used for adapters when the input doesn't start with <adapter. This change will prevent from generating detailed images that are too big to normally view when the input is the entire configuration instead of just an adapter, and instead generates a minimal overview of the listeners and senders and connections between adapters.

This pull request also contains a new version of adapter2mermaid.xsl which includes some small bug fixes, and support for new features such as:

  • Exits with a name attribute instead of path
  • No exits specified
  • Showing extra info about adapters

@lenardvandermaas lenardvandermaas changed the title Add and accommodate Mermaid configuration flow xsl Create and accommodate configuration2mermaid.xsl and make changes to adapter2mermaid.xsl May 17, 2022
@nielsm5 nielsm5 requested a review from jkosternl November 16, 2023 08:39
Copy link
Contributor

@jkosternl jkosternl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test class MermaidFlowGeneratorTest.java is not the prettiest, but probably functionally Ok to continue and merge.

@nielsm5 nielsm5 merged commit c741577 into frankframework:master Nov 16, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants