Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalFileSystemPipe doesn't move/copy files to the root of a drive #1029

Closed
francisgw opened this issue Sep 2, 2020 · 2 comments · Fixed by #1040, #1044 or #1046
Closed

LocalFileSystemPipe doesn't move/copy files to the root of a drive #1029

francisgw opened this issue Sep 2, 2020 · 2 comments · Fixed by #1040, #1044 or #1046
Labels
Bug

Comments

@francisgw
Copy link

Describe the bug
When the action is set to move, ladybug reports that the operation was successful while in reality nothing happened. When the action is set to copy, ladybug reports an error saying "FileNotFoundException" for the destination and "Access is denied" for the file.

Category

  • Frank Console
  • Frank Framework
  • Ladybug

To Reproduce
Steps to reproduce the behavior:

  1. Write an adapter with LocalFileSystemPipe
  2. Set filename for an existing file on your computer
  3. Set destination to the root: C:\
  4. See when testing pipeline that neither copy or move are done

Expected behavior
Either both move and copy give the same error like "access is denied" or both report success and actually do the operation.

Environment:

  • Tomcat
  • Edge, Chrome
  • IAF Version 7.6-20200615.130305
@francisgw francisgw added the Bug label Sep 2, 2020
@gvanbrakel
Copy link
Contributor

To move or copy files from/to anywhere on the local filesystem, the root attribute must be specified, e.g. like "c:/". All file and folder references are relative to this root. When no root is specfied, it is equal to the 'current' directory.

gvanbrakel added a commit that referenced this issue Sep 7, 2020
@gvanbrakel
Fix #1029,#1030 improve FileSystem Ibisdoc and Javadoc
6d526f1
@gvanbrakel gvanbrakel linked a pull request Sep 7, 2020 that will close this issue
Fix #1029,#1030 improve FileSystem Ibisdoc and Javadoc #1040
Merged
nielsm5 pushed a commit that referenced this issue Sep 7, 2020
@gvanbrakel
Fix #1029,#1030 improve FileSystem Ibisdoc and Javadoc (#1040)
97b12af
@gvanbrakel gvanbrakel reopened this Sep 8, 2020
@gvanbrakel
Copy link
Contributor

Reopened, because the case where LocalFileSystem.root is empty was not tested.

gvanbrakel added a commit that referenced this issue Sep 8, 2020
@gvanbrakel
Fix #1029 Handling absolute paths in LocalFileSystem
059fd69
@gvanbrakel gvanbrakel linked a pull request Sep 8, 2020 that will close this issue
Fix #1029 Handling absolute paths in LocalFileSystem #1044
Merged
gvanbrakel added a commit that referenced this issue Sep 8, 2020
@gvanbrakel
Fix #1029 Handling absolute paths in LocalFileSystem (7.5)
0f57c99
@gvanbrakel gvanbrakel linked a pull request Sep 8, 2020 that will close this issue
Fix #1029 Handling absolute paths in LocalFileSystem (7.5) #1046
Merged
nielsm5 pushed a commit that referenced this issue Sep 8, 2020
@gvanbrakel
Fix #1029 Handling absolute paths in LocalFileSystem (7.5) (#1046)
ce090f1
nielsm5 pushed a commit that referenced this issue Sep 8, 2020
@gvanbrakel
Fix #1029 Handling absolute paths in LocalFileSystem (#1044)
5139ddb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
2 participants
@gvanbrakel @francisgw