Update dependencies for latest genproto version #47
Conversation
Generated by running: go get google.golang.org/genproto go mod tidy
|
Hey, thanks for your contribution @staktrace. I'll get this merged over the weekend. FYI, I'll squash merge since I prefer atomic commits, and for that, I'll re-write the PR title/description as that is used as the basis of the merge commit by my merge script. I want to see what they changed in proto gen stuff for why this var got renamed and if there might be other consequences. |
|
Hi @staktrace - so nice to see your contribution, I hope things are well. |
Looks like a variable in an upstream package got renamed.
staktrace
force-pushed
the
kartikaya.upgrade
branch
from
bcae4a8 to
4f9df54
Compare
|
Thanks! It looks like the CI was failing because one of the error messages changed as well. I've updated the PR such that And feel free to edit the PR as needed! |
camh-
changed the title
There was a problem hiding this comment.
Thanks for the update. I'll squash the two commits together as I prefer that all commits can pass CI, so the deps update needs to be combined with the code changes. I've updated the PR description to include the info from the commits as that will become the squash merge commit message.
|
Thanks! |
Update our dependencies to be compatible with the current latest release
of
google.golang.org/genprotoby running:This has broken a couple of small things, which are fixed here:
The generated var name for the embedded protobuf descriptors has
changed, so when
google.golang.org/grpcgot updated due to thegenproto update,
reflection/service.goneeded to be updated withthe new name. This was changed in reflection: generate protobuf files from grpc-proto grpc/grpc-go#5799.
The var name changed because its proto import changed as part of that
PR, and the var name is based on the import name.
The error message for when
SendHeaderis called multiple times on astream has changed which broke a test that was testing the error type
and string. This was changed upstream in server: return better status for context err when writing header grpc/grpc-go#5292.
Link: grpc/grpc-go#5799
Link: grpc/grpc-go#5292