Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use TransactionRequest everywhere #7040

Merged
merged 6 commits into from
Feb 9, 2024
Merged

refactor: use TransactionRequest everywhere #7040

merged 6 commits into from
Feb 9, 2024

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Feb 7, 2024 •
edited
Loading

Motivation

Previously we were using CallRequest, and an in-house TransactionRequest.

Solution

Switches to using TransactionRequest everywhere.

Depends on alloy-rs/alloy#178

@Evalir Evalir marked this pull request as ready for review February 7, 2024 21:36
@Evalir Evalir mentioned this pull request Feb 7, 2024
Merged
3 tasks
@Evalir Evalir requested a review from onbjerg February 8, 2024 01:22
mattsse
mattsse reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great,

pending alloy

crates/anvil/src/eth/backend/fork.rs Show resolved Hide resolved
mattsse
mattsse reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great,

pending alloy

onbjerg
onbjerg approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's add a note on transaction_request_to_typed that we want to remove it at some point, both in code and an issue?

also need ci passing

@Evalir
Copy link
Member Author

Evalir commented Feb 8, 2024

@onbjerg ci won't pass until we merge the main pr—the evm-inspectors crate uses the normal rpc types instead of the ones pointing to your branch

@onbjerg
Copy link
Member

onbjerg commented Feb 9, 2024

@Evalir main PR is merged, can you update this PR?

@Evalir Evalir requested review from onbjerg and mattsse February 9, 2024 14:23
@Evalir
Copy link
Member Author

Evalir commented Feb 9, 2024

ci seems hanged up?

@onbjerg
Copy link
Member

onbjerg commented Feb 9, 2024

we dont have unlimited runners so sometimes other prs need to finish before ci can run

@Evalir
Copy link
Member Author

Evalir commented Feb 9, 2024

doesn't seem like there's any pr running though

@Evalir Evalir force-pushed the evalir/dedupe-tx-request-anvil branch from 0887695 to 001d02a Compare February 9, 2024 15:50
@Evalir
Copy link
Member Author

Evalir commented Feb 9, 2024

needs alloy-rs/alloy#195

@Evalir
Copy link
Member Author

Evalir commented Feb 9, 2024

ci failure unrelated.

@Evalir Evalir merged commit ff391b5 into master Feb 9, 2024
19 of 20 checks passed
@Evalir Evalir deleted the evalir/dedupe-tx-request-anvil branch February 9, 2024 17:20
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Evalir @onbjerg @mattsse