Adds snapshot map to anvil metadata #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested changes
Nov 20, 2023
mattsse
approved these changes
Nov 20, 2023
crates/anvil/core/src/types.rs
Outdated
| @@ -217,6 +219,7 @@ pub struct AnvilMetadata { | |||
| pub latest_block_number: u64, | |||
| pub latest_block_hash: H256, | |||
| pub forked_network: Option<ForkedNetwork>, | |||
| pub snapshots: HashMap<U256, (u64, H256)>, | |||
There was a problem hiding this comment.
Updated. but curious, why is this important? or is it just for visual consistency?
(a bit more nitpicky, but perhaps the whole Backend::active_snapshots be a btree from the start, to avoid conversion here, and perhaps to slightly optimize its cleanup?
There was a problem hiding this comment.
or is it just for visual consistency?
just for that yes
but perhaps the whole Backend::active_snapshots
yeah that'd be easier, but since we only need this for this rpc call, should be fine to collect
mattsse
approved these changes
Nov 20, 2023
|
test failures unrelated #6371 |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I need external access to the list of anvil snapshots
my use case: I want to expose snapshot/revert functionality on Iron wallet, but it should be able to support snapshots created outside of it too. there's currently no way to get a list of snapshots unless I control their creation too
Solution
Adding them to the
anvil_metadataendpoint seemed like the intuitive solution. Not sure if there are unintended side-effects behind this? I can move to a dedicated endpoint if needed