fix(StdInvariant): correct targetArtifactSelector type
#524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
targetArtifactSelector
branch
from
deb96d7 to
bedb04e
Compare
The return type of `targetArtifactSelector` is `(string, bytes4[])[]`. See: <https://github.com/foundry-rs/foundry/blob/db8ea58ba607075ce0f39bb975a38da6b4889ea1/crates/evm/evm/src/executors/invariant/mod.rs#L377-L379>
DaniPopes
force-pushed
the
targetArtifactSelector
branch
from
bedb04e to
628262e
Compare
mds1
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Nice catch. Was targetArtifactSelector basically a no-op and not working at all before? This is a breaking change to the interface, but it's ok if it wasn't doing anything.
Ideally we can point users to somewhere explaining how to fix the breaking change as well, even if it's just fleshing out the PR description here more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type of
targetArtifactSelectoris(string, bytes4[])[].See: https://github.com/foundry-rs/foundry/blob/db8ea58ba607075ce0f39bb975a38da6b4889ea1/crates/evm/evm/src/executors/invariant/mod.rs#L377-L379