Fix Rubocop violations and merge Listing specs #9963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citizen428
approved these changes
Aug 24, 2020
pr-triage
bot
added
PR: partially-approved
Ridhwana
approved these changes
Aug 24, 2020
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Follow up to #9943
Other than fixing a few violations I merged the two sets of
Listingspecs which were flagged by rubocop-rspec and I disabledRSpec/MultipleMemoizedHelperswhich defaults to 5 maxlet()total which we clearly surpass. We can rivisit this decision if we find a better optimization strategy to initialize less data in the first place.Related Tickets & Documents
#9943
Added tests?