Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran Prettier on some markdown files #4599

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Ran Prettier on some markdown files #4599

merged 1 commit into from
Oct 28, 2019

Conversation

nickytonline
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

I came across this accidentally while merging latest upstream master into another branch of mine. The precommit failed because of linting errors but it still modified these files, so just popping in a separate PR as it's not related to my webpack work.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

It's no big deal

@nickytonline nickytonline requested a review from a team October 26, 2019 04:10
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 26, 2019
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 28, 2019
@benhalpern benhalpern merged commit 2299123 into forem:master Oct 28, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 28, 2019
@nickytonline nickytonline deleted the nickytonline/markdown-prettification branch October 28, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants