Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/fix initializeCommentDropdown.js #4318

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Refactor/fix initializeCommentDropdown.js #4318

merged 2 commits into from
Oct 9, 2019

Conversation

Amorpheuz
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

  • The file was already compliant, just needed to add 'use strict'.
  • Removed an unnecessary no-unused-vars rule disable.

Related Tickets & Documents

#3777

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@Amorpheuz
Fix eslint issues in initializeCommentDropdown.js
d187b68 
- file was already compliant, just needed to add
  'use strict'.
@Amorpheuz
remove unnecessary eslint rule
35c0239
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 8, 2019
@Amorpheuz Amorpheuz changed the title Refactor/fix initialize comment dropdown.js Refactor/fix initializeCommentDropdown.js Oct 8, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 9, 2019
@rhymes rhymes mentioned this pull request Oct 9, 2019
Closed
@benhalpern benhalpern merged commit fd1b003 into forem:master Oct 9, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 9, 2019
@Amorpheuz
Copy link
Contributor Author

@rhymes While continuing to work on another lint fix, I actually noticed the functions meant for adding the click-to-copy functionality on articles #1579 actually get triggered and post console error on clicking the comment dropdowns.

I think I have fixed it. Opening another PR!

@weekly-digest weekly-digest bot mentioned this pull request Oct 14, 2019
Closed
RakChamp25 pushed a commit to RakChamp25/dev.to that referenced this pull request Oct 15, 2019
@Amorpheuz @RakChamp25
Refactor/fix initializeCommentDropdown.js (forem#4318)
e5c96f3 
* Fix eslint issues in initializeCommentDropdown.js
- file was already compliant, just needed to add
  'use strict'.

* remove unnecessary eslint rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amorpheuz @rhymes @benhalpern