Add badges index page. #4236
Merged
Add badges index page. #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option for the look of unearned stickers would be to remove the
|
|
Would be awesome if it was like a real "sticker book", with random height and rotation variation. |
|
I actually prefer the look without |
JWesorick
force-pushed
the
feature/badges-index
branch
from
8ae86d1 to
d902ba1
Compare
benhalpern
approved these changes
Oct 6, 2019
There was a problem hiding this comment.
This is nice!
I think we can noodle on some stylistic changes after this is merged.
I like the gray filters, but I could see maybe a hover state that shows a faded preview.
We also may want to split these up or order them differently, but we can also let this get merged and make the changes after.
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
RakChamp25
pushed a commit
to RakChamp25/dev.to
that referenced
this pull request
Oct 15, 2019
* Add badges index page. * remove empty style rule. * Add spec for badges index. Fix case when not logged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add badges index page.
Related Tickets & Documents
Closes #4001
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?