added mod_roundrobin_notifications to user_policy.rb #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobherrington
suggested changes
Oct 7, 2019
There was a problem hiding this comment.
Thanks for making a pull request @akshayymahajan! 🚀
I would love to see a test that validates that this fixes the issue described in #4210.
Would you mind adding those to this PR?
Happy Hacktoberfest 🎃
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
|
Hi @jacobherrington. I have updated the PR with tests. |
jacobherrington
approved these changes
Oct 8, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
RakChamp25
pushed a commit
to RakChamp25/dev.to
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
mod_roundrobin_notificationswas missing frompermitted_attributesinuser_policy.rbwhich was preventing the community-success notification setting from getting saved. This PR addsmod_roundrobin_notificationstopermitted_attributesinuser_policy.rb.Related Tickets & Documents
Fixes #4210
Added to documentation?