Fix tabbing order of article engagement icons #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jacobherrington
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
Thanks for making a PR @meowwwls!! 🎉
This a super helpful fix, thanks for finding this 😉
I think this change looks good! Happy Hacktoberfest 🦇💻
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When navigating through the article cards with a keyboard, currently the engagement icons are tabbed to in different order than what you would expect visually. (Comments are tabbed to first even though visually, it is second). Logical focus order should follow visual order when possible so a keyboard user knows what to expect.
The fix was to change the order of the elements in the markup.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before:
After:
Added to documentation?