Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit access to the API actions when authorized by doorkeeper token #4170

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

lightalloy
Copy link
Contributor

@lightalloy lightalloy commented Oct 1, 2019

What type of PR is this? (check all applicable)

  • Security improvement

Description

User authorized with an OAuth token should only able to access endpoints that correspond to the selected scopes. In this pr, I limited access to creating and updating records in this case.

Related Tickets & Documents

#3715

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 1, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 1, 2019
@rhymes rhymes mentioned this pull request Oct 1, 2019
7 tasks
@maestromac maestromac merged commit 3c49073 into forem:master Oct 2, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 2, 2019
@lightalloy lightalloy deleted the 3715-limit_api_access branch March 9, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants