Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad coloring on follow button #4106

Closed
sierisimo opened this issue Sep 25, 2019 · 10 comments · Fixed by #4212
Closed

Bad coloring on follow button #4106

sierisimo opened this issue Sep 25, 2019 · 10 comments · Fixed by #4212
Labels
bug always open for contribution external contributors welcome contribution is welcome!

Comments

@sierisimo
Copy link

Describe the bug

When reading an article, sometimes the button is not clear on what it says given the colors.

To Reproduce

I found it on this article: https://dev.to/jmfayard/how-kotlin-makes-editing-your-gradle-build-less-frustrating-232l

Just going there, without dark mode or anything, I'm not sure if I'm following or not this particular user.

Expected behavior

Text with the follow status for this user should be visible or selectable

Screenshots

image

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Firefox
  • Version: 69.0.1
@maestromac maestromac added the bug always open for contribution label Sep 26, 2019
@Amorpheuz
Copy link
Contributor

Looks similar to #3968 with it occuring only on article pages.

@weekly-digest weekly-digest bot mentioned this issue Sep 30, 2019
Closed
@jessleenyc
Copy link
Contributor

@sierisimo I think the issue here is that the user chose the same background and text color for the button.

@saurabhdaware
Copy link
Contributor

How about having a DEV logo in edit profile that changes color as you change background color and color? This can help you tell if background color and color match properly.
something like:

(Sorry for my drawing skills I edited in instagram stories 😭 🤣 )

@jessleenyc
Copy link
Contributor

WOW, I love that idea.

@jessleenyc jessleenyc added the external contributors welcome contribution is welcome! label Sep 30, 2019
@jessleenyc
Copy link
Contributor

Also want to point out that #1774 offers another solution

@saurabhdaware
Copy link
Contributor

Cool, Can I give it a try?

@saurabhdaware
Copy link
Contributor

I loved the idea of input type=color. How about having a button beside textbox and user can either type color code in textbox or he can tap the button and select the color and that color code will appear in textbox.

This will make it easy to select

and we can keep that DEV logo preview beside for better understanding of contrast.

@saurabhdaware
Copy link
Contributor

image
Did a quick inspect

@jessleenyc
Copy link
Contributor

@saurabhdaware go for it!

@saurabhdaware
Copy link
Contributor

Thanks @jessleenyc I'll start working on it then! 🌻

@saurabhdaware saurabhdaware mentioned this issue Oct 3, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4106: Showing color preview in Edit Profile
5 participants
@sierisimo @jessleenyc @maestromac @Amorpheuz @saurabhdaware