Adding "fooof_get_model" to provide easier access to getting the actual model fit #7
Conversation
updating FOOOF.m to also fetch fooofed_spectrum and fooofed_freqs
update to also output fooofed_freq, fooofed_spectrum and _bg_fit
|
Hey! Just wanted to say sorry that I've been super slow on responding / looking through this properly (I'm traveling a lot at the moment) - but thank you for taking the time to add to this wrapper, and I will give any real comments once I have a chance (probably next week) to go through this, and merge it in if everything looks good! |
|
Hey @rajatsaxena Thanks for your work on this! I changed things up a little bit - to keep consistency with the prior version, and not change how "fooof_unpack_results" works, I moved your updates to a new function, now called "fooof_get_model". I think this is a useful, and more modular approach - often we want to just get results (so unpack_results is useful as it is), but when the model is needed get_model gives access to this part to. I also found a way to get _bg_fit - it turns out you need to use 'py.getattr' to make this work. I'm going to merge this in now, and then probably add a little bit more to make it easier to use get_model. Thanks for the submission! |
TomDonoghue
changed the title
|
Hi @TomDonoghue The changes look good. Thanks for updating and letting me know. Let me know if I can contribute in any other way. |
updating the matlab wrapper to also return the values of:
I also tried retrieving
_bg_fitbut since the variable name starts with_( not allowed in matlab); one cannot use it directly in the form offm._bg_fit. Is there any other way to fetch it? maybe from flattened_spectrum