Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deprecation warning #266

Merged
merged 2 commits into from
Jun 29, 2023
Merged

add deprecation warning #266

merged 2 commits into from
Jun 29, 2023

Conversation

voytek
Copy link
Contributor

@voytek voytek commented Jun 28, 2023

  • Check the language.
  • We might also want to add an explicit link to the specparam project as well, but that's maybe overkill for a warning message.

@voytek voytek added the 1.1 Targetted for a fooof 1.1 release. label Jun 28, 2023
@fooof-tools fooof-tools deleted a comment from codecov-commenter Jun 29, 2023
@fooof-tools fooof-tools deleted a comment from codecov-commenter Jun 29, 2023
@TomDonoghue TomDonoghue requested a review from ryanhammonds June 29, 2023 22:49
@TomDonoghue
Copy link
Member

@voytek - I made some direct edits to the wording here - do you want to check you like the updated text?

In terms of a link to specparam - might be overkill and I don't currently know what link to put exactly - but I added a mention of the Changelog - do you think that's useful?

@voytek voytek merged commit 6a1ba83 into main Jun 29, 2023
@TomDonoghue TomDonoghue deleted the dep_warning branch July 18, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhammonds ryanhammonds Awaiting requested review from ryanhammonds

Assignees
No one assigned
Labels
1.1 Targetted for a fooof 1.1 release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voytek @TomDonoghue