Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and Testing: Appmanager and Ctl commands changes #77

Merged
merged 3 commits into from
May 20, 2021
Merged

Refactor and Testing: Appmanager and Ctl commands changes #77

merged 3 commits into from
May 20, 2021

Conversation

wardner
Copy link
Contributor

@wardner wardner commented May 19, 2021

Re-created PR #70

adding changes

adding grpc-promise depencendy to the storage module

JDOC reviewing

Adding some changes in ctl

appmanager refactoring and test

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@wardner
Copy link
Contributor Author

wardner commented May 19, 2021

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request May 19, 2021
ref: string;
}

export interface AppRequest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this request for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The returned value for an privated method. But @rihernandez, can clarify this for us more.

@psanders psanders merged commit 66793b9 into fonoster:dev May 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants