kaobiblio: fix \sideparencite command (was not printing in margin) #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I didn't notice. If you don't change |
|
But see also #222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
\sideparencitehelper command was indeed calling\parencitebut without adding anything to the side margin.This change fixes it in my document but I'm not familiarized enough with the kaobook codebase to be sure of what I'm doing, so please don't hesitate to ask me to improve this PR.
What I did was basically mimick the way
\sidetextcitecombines the functionalities of\textciteand\sideciteand try to make this variant do the same.I don't personally use it but
\sidesuperciteseems a bit faulty too, it adds something to the side margin but not with the same level of details, should I try and make it look like other citation types as well?