Co-authored-by: Jan <jsteemann@users.noreply.github.com>

…13506)

Co-authored-by: jsteemann <jan@arangodb.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>

Co-authored-by: Jan <jsteemann@users.noreply.github.com>

Co-authored-by: Max Neunhöffer <max@arangodb.com>
Co-authored-by: Max Neunhoeffer <max@arangodb.com>

Co-authored-by: Jan <jsteemann@users.noreply.github.com>

Co-authored-by: Jan <jsteemann@users.noreply.github.com>

Co-authored-by: Ignacio Rodriguez <ignacio@fastmicroservices.com>

Co-authored-by: Jan <jsteemann@users.noreply.github.com>

…led (#13536)

Co-authored-by: Max Neunhöffer <max@arangodb.com>

Co-authored-by: Wilfried Goesgens <willi@arangodb.com>
Co-authored-by: Tobias Gödderz <tobias@arangodb.com>

…it's treated similarly to "type<irs::encryption>" (#13548)

* fix a crash in FieldIterator::next()

FieldIterator::next() unconditionally subtracts a value of 2 from the
end of its `_stack` member, which can make the operation point before
the beginning of the `_stack` storage of `_stack` has less than 2
members.
There is a follow-up check to check if the subtracted value is at least
a big as `_stack.begin()`, but this may be too late.
Using a debug STL build (`_GLIBCXX_DEBUG`) already crashes when
subtracting 2 from the container's end:

```
2021-02-10T01:28:38.955Z [============] runInArangod: Trying tests/js/server/aql/aql-arangosearch-count-optimization.js ...
/usr/include/c++/10/debug/safe_iterator.h:924:
In function:
    __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<arangodb::iresearch::FieldIterator::Level*,
    std::__cxx1998::vector<arangodb::iresearch::FieldIterator::Level,
    std::allocator<arangodb::iresearch::FieldIterator::Level> > >,
    std::__debug::vector<arangodb::iresearch::FieldIterator::Level>,
    std::random_access_iterator_tag>::_Self __gnu_debug::operator-(const
    _Self&,
    __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<arangodb::iresearch::FieldIterator::Level*,
    std::__cxx1998::vector<arangodb::iresearch::FieldIterator::Level,
    std::allocator<arangodb::iresearch::FieldIterator::Level> > >,
    std::__debug::vector<arangodb::iresearch::FieldIterator::Level>,
    std::random_access_iterator_tag>::difference_type)

Error: attempt to retreat a past-the-end iterator 2 steps, which falls
outside its valid range.

Objects involved in the operation:
    iterator @ 0x0x7f09585f93e0 {
      type = __gnu_cxx::__normal_iterator<arangodb::iresearch::FieldIterator::Level*, std::__cxx1998::vector<arangodb::iresearch::FieldIterator::Level, std::allocator<arangodb::iresearch::FieldIterator::Level> > > (mutable iterator);
      state = past-the-end;
      references sequence with type 'std::__debug::vector<arangodb::iresearch::FieldIterator::Level, std::allocator<arangodb::iresearch::FieldIterator::Level> >' @ 0x0x7f09585f9850
    }
```

* added CHANGELOG entry

* use pointers instead of iterators

Co-authored-by: Andrey Abramov <andrey@arangodb.com>

Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com>

…3881)

* Fix logging of urls when using `--log.level requests=debug`. There was an
  issue since v3.7.7 with the wrong URL being logged in request logging if
  multiple requests were sent over the same connection. In this case, the
  request logging only reported the first URL requested in the connection,

Fixes a memleak when running into an out-of-memory situation while repurposing an existing AqlItemBlock.

* wip

* 1st impl with embedded substreams

* wip

* made arena member

* poc implementation

* add string and boolean tests

* wip

* cleanup

* add gtests

* fix build

* use functors for reset

* fix file name casing

* another fix

* adress review comments

* fix mac build warnings

* adress review comments

…on (#13463)

Co-authored-by: Jan <jsteemann@users.noreply.github.com>

* add tests for the issue

* fix and more tests

* Update arangod/IResearch/IResearchAnalyzerFeature.cpp

Co-authored-by: Simran <Simran-B@users.noreply.github.com>

* fix mac build

* fix test run

Co-authored-by: Simran <Simran-B@users.noreply.github.com>