fix(android_intent_plus): remove package name from AndroidManifest #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In gradle 8 ou higher setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported.
|
Thanks for your contribution, but would be much better if you actually followed our contributors guide or at least looked at other open PRs to name the PR properly: https://github.com/fluttercommunity/plus_plugins/blob/main/CONTRIBUTING.md#55-create-a-pull-request |
vbuberen
changed the title
vbuberen
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In gradle 8 ou higher setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported.
Related Issues
*[Question]: #2611
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.