Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stack_trace.dart #85364

Merged
merged 2 commits into from
Jun 26, 2021
Merged

Update stack_trace.dart #85364

merged 2 commits into from
Jun 26, 2021

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jun 26, 2021

Dart roll containing Object.hash is messing this up.

This seems like a bug in the analyzer - @bwilkerson or @pq might know

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Jun 26, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Jun 26, 2021
@dnfield
Copy link
Contributor Author

dnfield commented Jun 26, 2021

Failures start in #85354

@Hixie
Copy link
Contributor

Hixie commented Jun 26, 2021

test-exempt: only affects comments (heh)

@dnfield
Copy link
Contributor Author

dnfield commented Jun 26, 2021

Screenshot from VSCode analyzer output:

image

You can see there that the analyzer somehow thinks this is trying to override Object.hash. But I can't reproduce this in a smaller project for some reason.

@dnfield
Copy link
Contributor Author

dnfield commented Jun 26, 2021

Filed dart-lang/sdk#46477

@dnfield
Copy link
Contributor Author

dnfield commented Jun 26, 2021

Merging this to unblock the engine roller.

@dnfield dnfield merged commit 8e60c08 into master Jun 26, 2021
@dnfield dnfield deleted the dnfield-patch-1 branch June 26, 2021 03:25
@pq
Copy link
Contributor

pq commented Jun 28, 2021

/fyi @scheglov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency: dart Dart team may need to help us team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants