Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle CocoaPods ffi stderr #102327

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Handle CocoaPods ffi stderr #102327

merged 1 commit into from
Apr 21, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 21, 2022 •
edited
Loading

The CocoaPods ffi stacks are logged to stderr, not stdout.

On this change I see:

Screen Shot 2022-04-21 at 1 14 22 PM

Fixes #99195

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically labels Apr 21, 2022
@jmagman jmagman self-assigned this Apr 21, 2022
@jmagman jmagman mentioned this pull request Apr 21, 2022
Closed
christopherfujino
christopherfujino approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOLGTM

@fluttergithubbot fluttergithubbot merged commit c9825d2 into flutter:master Apr 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
6eec362
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
312df2f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
d598fb8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
2aa1fb8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
d4fd8b4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
466b653
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
9454273
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
a0b881d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
5c363cb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
9ec64e3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
fac6622
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
2cb160e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
19e4739
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
2fe7cd9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
27c5336
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
cda5e46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
d0eeca0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
090a1bf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
dacfbdf
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Apr 27, 2022
@jmagman
Handle CocoaPods ffi stderr (flutter#102327)
b54d6a0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
d81c639
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
c47877c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
bd9ebb4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
94a1c7b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
a5e9ec2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
752ee98
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
e57c89f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
92e15e8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
f89066a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
b2d5a07
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
e889222
CaseyHillers pushed a commit that referenced this pull request Apr 27, 2022
@jmagman @elliette
[flutter_releases] Flutter beta 2.13.0-0.3.pre Framework Cherrypicks (#…
5293f3c 
…102620)

* Handle CocoaPods ffi stderr (#102327)

* Hide unresolved DartUri log messages (#102338)

* 'Create candidate branch version flutter-2.13-candidate.0 for beta'

* 'Update Engine revision to 3096903c8923608d3c1ccf8058a29c31a2bfbc53 for beta release 2.13.0-0.3.pre'

* Update release-candidate-branch.version

* Update packages/flutter_tools/lib/src/macos/cocoapods.dart

* Remove skipped test from CP issue

Co-authored-by: Jenn Magder <magder@google.com>
Co-authored-by: Elliott Brooks (she/her) <21270878+elliette@users.noreply.github.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
d000963
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
79908db
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
1af779d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
c9825d2 Handle CocoaPods ffi stderr (flutter/flutter#102327)
f28ff03
@jmagman jmagman deleted the ffi-stderr branch May 4, 2022 02:15
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@jmagman @egramond
Handle CocoaPods ffi stderr (flutter#102327)
4cdd2b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
platform-ios iOS applications specifically platform-mac Building on or for macOS specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

library.rb:275: [BUG] Bus Error at 0x00000001042fc000
3 participants
@jmagman @christopherfujino @fluttergithubbot