Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change dependency from ios_signing to apple_signing #102259

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Change dependency from ios_signing to apple_signing #102259

merged 3 commits into from
Apr 21, 2022

Conversation

drewroengoogle
Copy link
Contributor

@drewroengoogle drewroengoogle commented Apr 20, 2022 •
edited
Loading

… it's use

This is related to bug #100910

Updates the dependency name to apple_signing for better readability. This dependency has already been added in the recipes repository.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

keyonghan
keyonghan approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drewroengoogle drewroengoogle merged commit ec6481b into flutter:master Apr 21, 2022
@drewroengoogle drewroengoogle linked an issue Apr 21, 2022 that may be closed by this pull request
Rename dependency ios_signing to apple_signing #100910
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
42275d5 
…flutter#102259)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
78b1ecf 
…flutter#102259)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
dfe7768 
…flutter#102259)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
894e052 
…flutter#102259)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
04f84b6 
…flutter#102259)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
56b534c 
…flutter#102259)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
b5c0327 
…flutter#102259)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
d5d9e4f 
…flutter#102259)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
4f27125 
…flutter#102259)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
e119642 
…flutter#102259)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
3c1fe9e 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
c718006 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
d212481 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
9bef532 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
c1d716d 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
2347b92 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
e67ad5b 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
cc02fee 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
36a7b5b 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
5a4e1a9 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
5947f7c 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
05eeaed 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
15886bb 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
ae98f6a 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
b161583 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
1729013 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
9914bfc 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
7face24 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
56be94b 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
fe4d4d7 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
0cb0615 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
e26026f 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
6e636de 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
dc558c5 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
7c97506 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
66ac646 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
bb969ea 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
e300405 
…flutter#102259)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
ec6481b Change dependency from ios_signing to apple_signing (flutter/…
02d3e37 
…flutter#102259)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@drewroengoogle @egramond
Change dependency from ios_signing to apple_signing (flutter#102259)
a53e34c 
* Change dependency name to apple_signing for a better understanding of it's use

* Updated Mac_ios test to run if .ci.yaml is updated
@drewroengoogle drewroengoogle deleted the ios_to_apple_signing branch December 13, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

@godofredoc godofredoc godofredoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename dependency ios_signing to apple_signing
3 participants
@drewroengoogle @godofredoc @keyonghan