Replace devtools_tool exe with shorthand dt
#8403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
approved these changes
Oct 4, 2024
DanTup
added a commit
to DanTup/devtools
that referenced
this pull request
Oct 7, 2024
flutter#8403 changed devtools_tool to dt, but only left a temporary compatibility wrapper for Mac/Linux. We need the same for Windows, otherwise: 1. Any users running `devtools_tool` may trigger the bash script and Windows will ask "What do you want to open this file with?" 2. Using the `dart.customDevTools` setting in VS Code assumes `devtools_tool` so it fails to start DevTools As a temporary measure, we should put this wrapper script in similar to the Mac/Linux version. I'll update Dart-Code to not assume `devtools_tool` exists in a future version (when it's less likely contributors are on older branches without the `dt` file).
kenzieschmoll
pushed a commit
that referenced
this pull request
Oct 7, 2024
…8410) #8403 changed devtools_tool to dt, but only left a temporary compatibility wrapper for Mac/Linux. We need the same for Windows, otherwise: 1. Any users running `devtools_tool` may trigger the bash script and Windows will ask "What do you want to open this file with?" 2. Using the `dart.customDevTools` setting in VS Code assumes `devtools_tool` so it fails to start DevTools As a temporary measure, we should put this wrapper script in similar to the Mac/Linux version. I'll update Dart-Code to not assume `devtools_tool` exists in a future version (when it's less likely contributors are on older branches without the `dt` file).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the repo tool for the flutter engine repo
et.devtools_toolcan be cumbersome to type, so this is a small workflow improvement.devtools_toolwill still be an alias for a fixed period of time until we remove it completely.Fixes #8384.