[Deep link] Generate AASA template when it doesn't exist #8345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannah-hyj
requested review from
kenzieschmoll
and removed request for
a team
kenzieschmoll
approved these changes
Sep 27, 2024
| _FailureDetails(errors: [error]), | ||
| ], | ||
| ), | ||
| error == IosDomainError.existence |
There was a problem hiding this comment.
the ternary check can be when defining the children of _IssuesBorderWrap since that is repeated:
_IssuesBorderWrap(
children: error == IosDomainError.existence ? [...] : [...],
)
| _FailureDetails( | ||
| errors: [error], | ||
| oneFixGuideForAll: | ||
| 'To fix this issues, add an Apple-App-Site-Association file at the following location: ' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't have an API for AASA generation. However, for users that don't have an AASA file, we can provide a template that's easy to copy-paste.
Pre-condition - Developer has an associated domain in "entitlements", but EXISTENCE check failed at ERROR severity level.
Assumption - The developer has appID as TEAMID.bundle.id and a associated domain like www.example.com
Generated template (Apple documentation):
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.