Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deep link] Check severityLevel and stop showing warnings (treat them as passing) #8344

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Sep 24, 2024

Eventual solution should be showing different scheme for errors and warnings(warnings are just recommendations), For now (this PR) we choose to omit warnings to reduce noise.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

@hannah-hyj hannah-hyj requested a review from a team as a code owner September 24, 2024 17:58
@hannah-hyj hannah-hyj requested review from elliette and kenzieschmoll and removed request for a team and elliette September 24, 2024 17:58
@hannah-hyj hannah-hyj merged commit e83d965 into flutter:master Sep 27, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants