[deep link] Make path a class to add isExclude and queryParam #8307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannah-hyj
requested review from
elliette and
kenzieschmoll
and removed request for
a team and
elliette
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_controller.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_services.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_services.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Sep 9, 2024
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_controller.dart
Outdated
Show resolved
Hide resolved
| @@ -552,7 +552,7 @@ class DeepLinksController extends DisposableController | |||
| false); | |||
|
|
|||
| if (linkdata.os.contains(PlatformOS.ios)) { | |||
| final List<String> iosPaths = iosDomainPaths[linkdata.domain] ?? []; | |||
| final List<Path> iosPaths = iosDomainPaths[linkdata.domain] ?? []; | |||
There was a problem hiding this comment.
remove type on LHS. There should be a lint that catches this, and the DCM check on the CI should catch this too, so maybe we have a bug. But please remove type on LHS and add it to the null case empty list.
| @@ -552,7 +552,7 @@ class DeepLinksController extends DisposableController | |||
| false); | |||
|
|
|||
| if (linkdata.os.contains(PlatformOS.ios)) { | |||
| final List<String> iosPaths = iosDomainPaths[linkdata.domain] ?? []; | |||
| final iosPaths = iosDomainPaths[linkdata.domain] ?? []; | |||
There was a problem hiding this comment.
add the type to the empty list or else this would be dynamically typed when iosDomainPaths[linkdata.domain] is null
hannah-hyj
force-pushed
the
ios-exclude-path
branch
from
3035615 to
e5a8949
Compare
kenzieschmoll
approved these changes
Sep 11, 2024
add isExcluded 1 add aasa path 1 add key Add tests
hannah-hyj
force-pushed
the
ios-exclude-path
branch
from
bff67da to
01f29b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
A deeplink path in AASA file is more than just a string, it can have other attributions like
exclude,exclude : A Boolean value that indicates whether to stop pattern matching and prevent the universal link from opening if the URL matches the associated pattern. The default is false.
For a excluded path, we just display them as
NOT /pathin the path table.For other attributions, will add them in the UI later.
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.