[deep link] Only show path check table for android links #8286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannah-hyj
requested review from
elliette and
kenzieschmoll
and removed request for
a team and
elliette
| @@ -651,6 +651,11 @@ class _PathCheckTable extends StatelessWidget { | |||
|
|
|||
| @override | |||
| Widget build(BuildContext context) { | |||
| final linkData = controller.selectedLink.value!; | |||
There was a problem hiding this comment.
should we be null-asserting here? Or in other words are we confident the selected link will be non-null at this point?
There was a problem hiding this comment.
yes, we are confident a link is selected before showing the validation result.
hannah-hyj
force-pushed
the
pathcheckonlyanroid
branch
from
7fee2b0 to
3a0bdc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path check table is displaying errors from android manifest file, only show it for android links, not ios.
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.