[deep link] Add ios path from AASA file check result. #8285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_controller.dart
Outdated
Show resolved
Hide resolved
Comment on lines
+549
to
+554
| final hasAndroidAssetLinksFile = !(androidDomainErrors[linkdata.domain] | ||
| ?.contains(AndroidDomainError.existence) ?? | ||
| false); | ||
| final hasIosAasaFile = !(iosDomainErrors[linkdata.domain] | ||
| ?.contains(IosDomainError.existence) ?? | ||
| false); |
There was a problem hiding this comment.
is defaulting to false what we want here? The way I am understanding this is that if we have no domain errors, we assume the asset links or aasa files do not exist.
There was a problem hiding this comment.
If we have no domain errors, hasAndroidAssetLinksFile =! ( null ?? false ) = true .
if the domain doesn't have asset links or aasa files. the domain errors should return AndroidDomainError.existence or IosDomainError.existence.
If we have no domain errors, we assume the domain has asset links or aasa files.
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_controller.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_services.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_services.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_services.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep link android paths are read from android manifest file.
Deep link ios paths are from the web AASA file , so we read it from the validation RPC and show them in the validation result.
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.