Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for default interface and explicitly implemented properties #2794

Conversation

dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Oct 28, 2024

Reimplemented the Reflection process using a content-only open-source library needed to find all types of properties and fields including default interface properties.

Fixes #2754 and #2759

Copy link

github-actions bot commented Oct 28, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Oct 28, 2024

Pull Request Test Coverage Report for Build 11739667739

Details

  • 40 of 41 (97.56%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 97.291%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Src/FluentAssertions/Equivalency/MemberVisibilityExtensions.cs 29 30 96.67%
Totals Coverage Status
Change from base Build 10774112131: -0.05%
Covered Lines: 12965
Relevant Lines: 13208

💛 - Coveralls

@dennisdoomen dennisdoomen marked this pull request as ready for review October 28, 2024 21:16
@ITaluone
Copy link
Contributor

🤔 Missing release notes and/or documentation?

@ITaluone
Copy link
Contributor

image

Do we really want this?

@dennisdoomen
Copy link
Member Author

image

Do we really want this?

Nope. You're right. I need to fix that.

@dennisdoomen dennisdoomen force-pushed the fix/default-interface-property branch from c81b709 to 51c118f Compare October 29, 2024 10:45
Build/Build.cs Outdated Show resolved Hide resolved
@dennisdoomen dennisdoomen force-pushed the fix/default-interface-property branch 2 times, most recently from 503f625 to 73f5bd3 Compare October 29, 2024 16:45
@dennisdoomen dennisdoomen force-pushed the fix/default-interface-property branch from 73f5bd3 to bfaaec8 Compare November 8, 2024 09:01
@dennisdoomen dennisdoomen force-pushed the fix/default-interface-property branch from bfaaec8 to f471413 Compare November 8, 2024 09:37
@dennisdoomen dennisdoomen merged commit c6cd85c into fluentassertions:master Nov 8, 2024
5 checks passed
@dennisdoomen dennisdoomen deleted the fix/default-interface-property branch November 8, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants