Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: Add how to handle WASM documentation #942

Merged
merged 9 commits into from
Oct 21, 2022

Conversation

cosmo0920
Copy link
Contributor

Signed-off-by: Hiroshi Hatake hatake@calyptia.com

Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few niggles and I think it needs a little intro plus some more references out to the tools used.
Can you also do a sentence per line to make it easier to review and ensure we use "Fluent Bit" everywhere?

development/wasm-filter-plugins.md Outdated Show resolved Hide resolved
development/wasm-filter-plugins.md Outdated Show resolved Hide resolved
development/wasm-filter-plugins.md Outdated Show resolved Hide resolved
development/wasm-filter-plugins.md Show resolved Hide resolved
development/wasm-filter-plugins.md Show resolved Hide resolved
development/wasm-filter-plugins.md Outdated Show resolved Hide resolved
development/wasm-filter-plugins.md Outdated Show resolved Hide resolved
development/wasm-filter-plugins.md Outdated Show resolved Hide resolved
development/wasm-filter-plugins.md Outdated Show resolved Hide resolved
development/wasm-input-plugins.md Outdated Show resolved Hide resolved
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Pat <patrick.j.k.stephens@gmail.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
@patrick-stephens patrick-stephens merged commit 67670cc into fluent:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants