Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix USB-UART bridge exit screen stopping the bridge prematurely #3892

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fix USB-UART bridge exit screen stopping the bridge prematurely #3892

merged 2 commits into from
Sep 12, 2024

Conversation

portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Sep 10, 2024 •
edited by skotopes
Loading

What's new

Verification

  • Open the USB-UART bridge
  • Configure bridge to use channel 1
  • Press the back key
  • Verify that the "Exit USB-UART" screen shows up but that the virtual COM port remains attached
  • Verify that selecting "Stay" returns to the main screen
  • Press the back key again
  • Verify that selecting "Exit" returns to the main GPIO screen and disposes of the virtual COM port

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Compiled f7 firmware for commit 396fcd54:

@skotopes skotopes marked this pull request as draft September 12, 2024 16:16
@portasynthinca3 portasynthinca3 marked this pull request as ready for review September 12, 2024 16:20
@skotopes skotopes merged commit 0428e82 into dev Sep 12, 2024
11 checks passed
@skotopes skotopes deleted the portasynthinca3/usbuart-stay-fix branch September 12, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPIO USB UART Bridge disconnects on confirm dialog
2 participants
@portasynthinca3 @skotopes