Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: improved size validator for updater image #3834

Merged
merged 3 commits into from
Aug 12, 2024
Merged

scripts: improved size validator for updater image #3834

merged 3 commits into from
Aug 12, 2024

Conversation

hedger
Copy link
Member

@hedger hedger commented Aug 11, 2024 •
edited by skotopes
Loading

What's new

  • scripts: update.py: reduced reservation size for flash memory; improved error messages; added checks for updater images

Verification

  • In targets/f7/src/main.c, add unused globals:
#ifdef FURI_RAM_EXEC
uint8_t dummy_pad[20 * 1024] = {1};
#else
uint8_t dummy_pad[114 * 1024] = {1};
#endif

int main(void) {
    dummy_pad[1] += 1;
  • Build update bundle
  • Try 104 kb pad for flash to check other error message

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger
scripts: update.py: reduced reservation size for flash memory; improv…
4cd5d07 
…ed error messages; added checks for updater images
@hedger hedger added the Build System & Scripts fbt, scripts and toolchain-related label Aug 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2024 •
edited
Loading

Compiled f7 firmware for commit 60554e4e:

@hedger hedger changed the title scripts: updated size validator for updater image scripts: improved size validator for updater image Aug 12, 2024
@skotopes skotopes merged commit 99655c1 into dev Aug 12, 2024
11 checks passed
@skotopes skotopes deleted the hedger/updater_sz_checks branch August 12, 2024 01:09
ofabel pushed a commit to ofabel/flipperzero-firmware that referenced this pull request Sep 26, 2024
@hedger @skotopes @ofabel
scripts: improved size validator for updater image (flipperdevices#3834)
e428836 
* scripts: update.py: reduced reservation size for flash memory; improved error messages; added checks for updater images
* scripts: update: fixed imports

Co-authored-by: あく <alleteam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes