Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assets: checking limits on image size; ufbt: cdb target #3359

Merged
merged 4 commits into from
Jan 12, 2024
Merged

assets: checking limits on image size; ufbt: cdb target #3359

merged 4 commits into from
Jan 12, 2024

Conversation

hedger
Copy link
Member

@hedger hedger commented Jan 11, 2024 •
edited by skotopes
Loading

What's new

Verification

  • put an image larger than 128x64 in assets or app's private images
  • build
  • install SDK for ufbt; check vscode_dist and new cdb targets
  • try vscode_dist on clean clone - should also create cdb.json

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 11, 2024 •
edited
Loading

Compiled f7 firmware for commit f87cd3b4:

@hedger hedger added Bug Build System & Scripts fbt, scripts and toolchain-related labels Jan 11, 2024
@hedger hedger changed the title scripts: assets: checking limits on image size assets: checking limits on image size; ufbt: cdb target Jan 11, 2024
@hedger hedger added the New Feature Contains an IMPLEMENTATION of a new feature label Jan 11, 2024
@skotopes skotopes merged commit 0789cbd into dev Jan 12, 2024
9 checks passed
@skotopes skotopes deleted the hedger/gh3357-imagechecks branch January 12, 2024 08:58
RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Jan 12, 2024
@hedger @skotopes @RogueMaster
assets: checking limits on image size; ufbt: cdb target (flipperdevic…
8957829 
…es#3359)

* scripts: assets: checking limits on image size
* ufbt: added "cdb" target for regenerating; also generating cdb on "vscode_dist"
* fbt: now also creating cdb for vscode_dist

Co-authored-by: あく <alleteam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
Bug Build System & Scripts fbt, scripts and toolchain-related New Feature Contains an IMPLEMENTATION of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon bitmaps with over 1024 bytes of uncompressed 1-bit data unintentionally wrap buffer data on decode
2 participants
@hedger @skotopes