Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous fixes #32

Merged
merged 2 commits into from
Nov 6, 2017
Merged

Miscellaneous fixes #32

merged 2 commits into from
Nov 6, 2017

Conversation

jeremyruppel
Copy link
Member

  • layoutConfig and layoutData were scoped to the module, not the exported function invocation. Sloppy.
  • Fixed the spacing in all our block comments.

@coveralls
Copy link

coveralls commented Aug 19, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling f7a68f8 on jeremyruppel:fixups into cf6238d on flickr:master.

@superic
Copy link

superic commented Aug 20, 2016

👍 ship it

@superic
Copy link

superic commented Aug 25, 2016

Such beauty. Much good. Very merge.

@pdokas
Copy link
Member

pdokas commented Nov 6, 2017

@jeremyruppel If you rebase this on master I’d be happy to merge it!

@coveralls
Copy link

coveralls commented Nov 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6693811 on jeremyruppel:fixups into a4ace4c on flickr:master.

@coveralls
Copy link

coveralls commented Nov 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 5f3124a on jeremyruppel:fixups into a4ace4c on flickr:master.

@jeremyruppel
Copy link
Member Author

Done!

pdokas
pdokas approved these changes Nov 6, 2017
View reviewed changes
Copy link
Member

@pdokas pdokas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pdokas pdokas merged commit ebd2bf1 into flickr:master Nov 6, 2017
This was referenced Nov 16, 2020
Open
Closed
@Joniali078 Joniali078 mentioned this pull request Feb 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdokas pdokas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremyruppel @coveralls @superic @pdokas