Fix #2419 breaking with altInput and altFormat Enabled #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshibuya
commented
Mar 12, 2022
| expect(fp._input.value).toBe("22 January 2020 03:04"); | ||
| }); | ||
|
|
||
| it("should trigger onChange only once", () => { |
There was a problem hiding this comment.
This test is for the issue mentioned here:
#2601 (comment)
mshibuya
commented
Mar 12, 2022
| @@ -817,6 +852,29 @@ describe("flatpickr", () => { | |||
| expect(fp.currentYear).toBe(2016); | |||
| }); | |||
|
|
|||
| it("onKeyDown closes flatpickr on Enter when allowInput set to true", () => { | |||
There was a problem hiding this comment.
This test is to ensure that this fix is covered:
https://github.com/flatpickr/flatpickr/pull/2419/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R1627
mshibuya
commented
Mar 12, 2022
| onChange: () => timesFired++, | ||
| }); | ||
| fp._input.focus(); | ||
| document.body.focus(); | ||
| simulate("blur", fp._input); |
There was a problem hiding this comment.
This needed to be changed, otherwise if I make an actual change onChange won't be fired.
mshibuya
commented
Mar 12, 2022
| !isCalendarElem(e.relatedTarget as HTMLElement); | ||
| !isInput && | ||
| !isCalendarElement && | ||
| !isCalendarElem(e.relatedTarget as HTMLElement); |
There was a problem hiding this comment.
Removing e.type === "blur" since it's confusing.
We used to accept blur events in the documentClick(), but we no longer after a7acd8f.
mshibuya
commented
Mar 12, 2022
| updateValue(); | ||
|
|
||
| if (self._input.value !== valueFromInput) { | ||
| if (self._input.value !== prevValue) { |
There was a problem hiding this comment.
These changes are the revert of #2419.
|
@chmln Could you review this? Looks like many people are having this issue. |
|
Hi, the behavior of 4.6.11 is now the same as 4.6.9, which was triggering an unexpected A reduced test case is available at https://jsfiddle.net/tagliala/bahnou4z/11/ Should I open a new issue? |
|
Yes please @tagliala |
kodiakhq bot
referenced
this pull request
in carbon-design-system/carbon-for-ibm-dotcom
Mar 21, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [flatpickr](https://flatpickr.js.org) ([source](https://togithub.com/chmln/flatpickr)) | [`4.6.10` -> `4.6.11`](https://renovatebot.com/diffs/npm/flatpickr/4.6.10/4.6.11) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chmln/flatpickr</summary> ### [`v4.6.11`](https://togithub.com/chmln/flatpickr/releases/v4.6.11) [Compare Source](https://togithub.com/chmln/flatpickr/compare/v4.6.10...v4.6.11) There was a bug with time selection since so much stuff got merged in. New tests have been added to prevent this from happening again. #### What's Changed - Fix [#​2419](https://togithub.com/chmln/flatpickr/issues/2419) breaking with altInput and altFormat Enabled by [@​mshibuya](https://togithub.com/mshibuya) in [https://github.com/flatpickr/flatpickr/pull/2662](https://togithub.com/flatpickr/flatpickr/pull/2662) - Bug fix: error thrown and calendar UI broken by invalid input value when allowInput is true and allowInvalidPreload is true by [@​barszczmm](https://togithub.com/barszczmm) in [https://github.com/flatpickr/flatpickr/pull/2650](https://togithub.com/flatpickr/flatpickr/pull/2650) #### New Contributors - [@​barszczmm](https://togithub.com/barszczmm) made their first contribution in [https://github.com/flatpickr/flatpickr/pull/2650](https://togithub.com/flatpickr/flatpickr/pull/2650) **Full Changelog**: flatpickr/flatpickr@v4.6.10...v4.6.11 </details> --- ### Configuration 📅 **Schedule**: "every weekend" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I noted in #2653 (comment), #2419 didn't handle altFormat properly and caused the issue #2653 and #2660.
This PR fixes the issue, by removing most of the fix from #2419. That's because It turned out that the fix made by #2541 and #2601 also addresses the issue #2419 was trying to solve.