Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_crau: parse signature header #9

Merged
merged 1 commit into from
Jul 5, 2023
Merged

update_crau: parse signature header #9

merged 1 commit into from
Jul 5, 2023

Conversation

dongsupark
Copy link
Member

@dongsupark dongsupark commented Jun 29, 2023 •
edited
Loading

Parse signatures header, check for signature versions.

Fixes flatcar/Flatcar#1025

@dongsupark dongsupark mentioned this pull request Jun 29, 2023
Closed
2 tasks
wrl
wrl requested changes Jul 3, 2023
View reviewed changes
update-format-crau/src/bin/test.rs Outdated Show resolved Hide resolved
update-format-crau/src/bin/test.rs Outdated Show resolved Hide resolved
update-format-crau/src/bin/test.rs Outdated Show resolved Hide resolved
@dongsupark dongsupark force-pushed the dongsu/sig-header branch from cac4b60 to 37f9f6f Compare July 3, 2023 15:14
wrl
wrl reviewed Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@wrl wrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's a few suggestions about things i think could be written in slightly more "idiomatic rust". imo, rust is a lot happier being written in a more combinator-heavy style.

up to you whether to incorporate the feedback, of course :)

update-format-crau/src/bin/test.rs Outdated Show resolved Hide resolved
update-format-crau/src/bin/test.rs Outdated Show resolved Hide resolved
update-format-crau/src/bin/test.rs Outdated Show resolved Hide resolved
@dongsupark dongsupark force-pushed the dongsu/sig-header branch from 37f9f6f to 0a6d42d Compare July 5, 2023 13:13
@dongsupark dongsupark marked this pull request as ready for review July 5, 2023 13:17
wrl
wrl approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@wrl wrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you'll permit me one last little coding style nitpick, i'll be happy to merge this :)

update-format-crau/src/bin/test.rs Outdated Show resolved Hide resolved
@dongsupark
update_crau: parse signature header
fb37041 
Parse signatures header, check for signature versions.
@dongsupark dongsupark force-pushed the dongsu/sig-header branch from 0a6d42d to fb37041 Compare July 5, 2023 17:19
@wrl wrl merged commit 68c708a into trunk Jul 5, 2023
@dongsupark dongsupark deleted the dongsu/sig-header branch July 6, 2023 08:13
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pothos pothos pothos left review comments

@wrl wrl wrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse/decode CrAU protobuf format
3 participants
@dongsupark @wrl @pothos